Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecation warning from get_description #3819

Merged
merged 1 commit into from
Mar 2, 2020
Merged

remove deprecation warning from get_description #3819

merged 1 commit into from
Mar 2, 2020

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Mar 2, 2020 •
edited
Loading

fix #3818

The description property is understood to return the value stored in
the description column, while get_description may be a compound of
various columns/attributes.

Reverting incorrect deprecation of get_description for the Code class.

@ltalirz
remove deprecation warning from get_description
1d86071 
The `description` property is understood to return the value stored in
the description column, while `get_description` may be a compound of
various columns/attributes.

Reverting incorrect deprecation of get_description for the Code class.
giovannipizzi
giovannipizzi approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@giovannipizzi giovannipizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ltalirz ltalirz merged commit d5a706f into aiidateam:develop Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giovannipizzi giovannipizzi giovannipizzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove wrong deprecation warning for get_description
2 participants
@ltalirz @giovannipizzi